[Frugalware-devel] patch for rox.sh

[Miklos Vajna]

On Tue, Apr 15, 2008 at 11:18:11AM +0000, Flaker Oats <flakeroats at hotmail.com> wrote:
> I have attached a git patch for rox.sh. If it goes well, I'll try my
> hand on the unmaintained rox-extra branch.

a few comments below.

>  ###
>  # = rox.sh(3)
> -# Marcus Habermehl <bmh1980 at frugalware.org>
> +#
> +# Updated by: James Buren <flakeroats at hotmail.com>
> +# Original author: Marcus Habermehl <bmh1980 at frugalware.org>

try to type 'make rox.sh.3' to check for syntax errors, only one author
is allowed for a manpage.

>  # depends=('libgtop' 'rox-clib')
> -# _F_app_dir="Load"
> +# _F_appname="Load"

if you change this, the change it to _F_rox_name.

> +# * _F_rox_appname - name of the rox app to install (mandatory)

typo? there is no _F_rox_appname in the example.

> +# * _F_rox_lib - set to 1 if installing a rox library (optional)
> +# * _F_rox_updatename - used to finetune the default up2date (optional)
> +# * _F_rox_updateext - used to finetune the default up2date (optional)
> +# * _F_rox_seperator - use if you have an unusual directory path to the appdir (optional)
> +# == INTERNALS - DO NOT CHANGE
> +# * _F_rox_installpath - internal variable set based on the value of _F_rox_lib
> +# * _F_rox_fullpath - full path to App
> +# * _F_rox_appdir - used to adjust the current directory
>  ###

just don't document internal variables in the manpage. one is supposed
to touch only the documented _F_foo variables. ie.: you can just use
comments in the source, but outside the

###
# foo
###

block.

>  ###
> -# * build() just calls Froxbuild()
> +# * build() calls all the rox build subroutines in their correct order.
> +# * only modify if the defaults will not work
>  ###
> +
>  build()
>  {
> -	Froxbuild

having an Froxbuild would be still useful, in case you just want to
append/prepend something to the normal build. see mono.sh, kde.sh, etc.

(though if you are at it, you can rename it to Fbuild_rox, that's the
recent naming scheme we use.)

> +	Frox_setup
> +	Frox_compile
> +	Frox_mkdir
> +	Frox_install
> +	Frox_cleanup
> +	Fmessage "Proceeding to final preparation phase..."

this Fmessage is unnecessary.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
Url : /pipermail/attachments/20080416/ff9b7d4d/attachment.sig