[Frugalware-devel] FB review netbeans

[Miklos Vajna]

On Wed, Mar 12, 2008 at 11:57:45PM +0100, gaetan <bouleetbil at frogdev.info> wrote:
> pkgname=netbeans
> pkgver=6.0.1

wow, great! :) some comments below

> pkgrel=1
> pkgdate=200801291616
> pkgdesc="The original free Java IDE, and so much more."
> url="http://www.netbeans.info/"
> source=(http://download.netbeans.org/$pkgname/6.0/final/zip/$pkgname-$pkgver-$pkgdate-src.zip)
> 
> Vers=6.0

this is unnecessary, you can use ${pkgver%.?} (so that you can avoid
hardcoding 6.0 and the variable as well.)

> url="http://download.netbeans.org/$pkgname/$Vers/final/zip/"

probably you want to name this pkgurl or something like that, so the
package will still have the original url (which is more interesting for
users)

> 	echo
> nb.clusters.list=nb.cluster.nb,nb.cluster.platform,nb.cluster.ide,nb.cluster.ruby,nb.cluster.java,nb.cluster.apisupport,nb.cluster.harness>>
> nbbuild/user.build.properties # for now build using Sun's javac export
> JAVA_HOME=/usr/lib/java #if you want latest source

this is messy, you probably want a newline here as "# for now build
using Sun's javac export" is a comment for JAVA_HOME

> 	#ant -f build.xml checkout || return 1
>         #-Dpermit.jdk6.builds=true for force jdk6 and not 5
> 	ANT_OPTS="-Xmx512M" ant -f nbbuild/build.xml
> -Dstop.when.broken.modules=true -Dbuild.compiler.deprecation=true
> -Dpermit.jdk6.builds=true || return 1 cd $Fsrcdir/nbbuild || return 1 #
> bin non-Linux binaries find * -type f  -name "*.exe" -o \
>  	                -name "*.cmd" -o \
> 	                -name "*.bat" -o \
>  	                -name "*.dll"     \
>  	                | xargs rm -f

this is ok but completely messed up regarding newlines - i would
recommend you to attach your FrugalBuilds instead of copy&pasting them
:)

> 	# for launch
> 	echo "#!/bin/sh" > netbeans.sh
> 	echo "/usr/lib/netbeans/bin/netbeans $@" >> netbeans.sh

you want '' here instead of ""

> 	chmod +x netbeans.sh || return 1
> 	mv netbeans.sh $Fdestdir/usr/bin/netbeans || return 1

you can use Fwrapper for this. (see man util.sh)

the rest looks ok. i wrote these comments so that you can learn, but
i've corrected these myself. i've started a build, if it builds fine for
me then i'll push it.

thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : /pipermail/attachments/20080313/1eb499bb/attachment.sig