[Frugalware-devel] FB review libytnef

[gaetan (bouleetbil)]

Le Thu, 13 Mar 2008 14:54:22 +0100,
Miklos Vajna <vmiklos at frugalware.org> a écrit :

> On Wed, Mar 12, 2008 at 11:55:07PM +0100, gaetan
> <bouleetbil at frogdev.info> wrote:
> > # Compiling time: 1.67 SBU
> 
> are you sure this is correct? i got:
> 
> ==> Elapsed Time: 0.15 SBU
> 
> this is a big difference.

Hello,
no sorry it's an error

> 
> > # Maintainer: bouleetbil at frogdev.info
> > 
> > pkgname=libytnef
> > pkgver=1.5
> > pkgrel=1
> > pkgdesc="Stream Reader"
> 
> feel free to copy the full description (here: "Yerase's TNEF Stream
> Reader") from the homepage if it's less then 80 chars.
Ok for 80 chars

> > archs=('i686' 'x86_64')
> > options=('scriptlet')
> > groups=('lib-extra')
> > depends=()
> 
> makepkg -a says it depends on glibc.
I forget this depend
> 
> > _F_sourceforge_dirname="ytnef"
> > _F_sourceforge_broken_up2date="1"
> > Finclude sourceforge
> > url="http://ytnef.sourceforge.net/"
> 
> sourceforge.sh already sets url, so this it not really necessary :)
I didn't know

> 
> the rest looks fine. thanks for the package, pushed.

thanks for the corrections ;-)

-- 
#--------------------------------------------------------------------------- 
#                            Bouleetbil
#
#---------------------------------------------------------------------------  
#     http://www.frogdev.info
#             _    _
#            (o)--(o)
#           /.______.\
#           \________/
#          ./        \.
#         ( .        , )
#          \ \_\\//_/ /
#           ~~  ~~  ~~
#--------------------------------------------------------------------------- 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
Url : /pipermail/attachments/20080313/8ea956e1/signature.asc