[Frugalware-devel] FB review racc

[gaetan (bouleetbil)]

Le Fri, 14 Mar 2008 21:48:03 +0100,
Miklos Vajna <vmiklos at frugalware.org> a écrit :

> On Thu, Mar 13, 2008 at 10:43:54PM +0100, gaetan
> <bouleetbil at frogdev.info> wrote:
> > # Compiling Time: 0.01 SBU
> > # Maintainer: bouleetbil <bouleetbil at frogdev.info>
> > 
> > pkgname=racc
> > pkgver=1.4.5
> > pkgrel=1
> > _F_archive_name=$pkgname-$pkgver-all
> > pkgdesc="A LALR(1) parser generator for Ruby"
> > url="http://www.loveruby.net/en/racc.html"
> > source=("http://i.loveruby.net/archive/racc/$_F_archive_name.tar.gz")
> > depends=('ruby')
> > groups=('lib-extra')
> > archs=('i686')
> > _F_cd_path=$_F_cd_path$_F_archive_name
> 
> this is a bit messed up. the problem here you try to solve (i think)
> is that the "-all" suffix appears in the tarball and in the source
> url as well. if you just set _F_cd_path (set, don't append) and use
> it in source() then you van avoid _F_archive_name (which is something
> you want, since that variable is for Flastarchive, and friends)
> 
> > up2date="lynx -dump lynx -dump  $url |grep tar.gz |  grep $pkgname-
> > | cut -d '-' -f 2"
> > sha1sums=('80ec24d4c9db09812514b5b2f0db988ce7de2898') build()
> > {
> > 	Fcd || Fdie
> > 	ruby setup.rb config || Fdie
> > 	ruby setup.rb setup	|| Fdie
> > 	ruby setup.rb install --prefix=$Fdestdir || Fdie
> > }
> 
> hmm, this build() could be avoided if we would support setup.rb in
> Fbuild. so i've added support for it, so the FB i pushed has no
> build() :)
> 
> to sum up: thanks, pushed, and this one was almost perfect! :)
Hello,
Thanks, I have looked at your FB and it is clearer I'm just a
learner ;-)


-- 
#--------------------------------------------------------------------------- 
#                            Bouleetbil
#
#---------------------------------------------------------------------------  
#     http://www.frogdev.info
#             _    _
#            (o)--(o)
#           /.______.\
#           \________/
#          ./        \.
#         ( .        , )
#          \ \_\\//_/ /
#           ~~  ~~  ~~
#--------------------------------------------------------------------------- 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
Url : /pipermail/attachments/20080314/190c62d4/signature.asc