[Frugalware-devel] FB review claws-mail-extra-plugins

[Miklos Vajna]

On Sun, Mar 16, 2008 at 08:40:07PM +0100, gaetan <bouleetbil at frogdev.info> wrote:
>     for dir in `ls`; do
>         # Continue if it is not a directory or the synce plugin
>         [ ! -d "$dir" ] && continue
> 	#for don't make plugin sync
>      	echo "$dir" | grep synce >/dev/null 2>/dev/null && continue 
>         cd "$dir"
> 	Fconf
>        	Fmake
> 	Fmakeinstall
> 	#install split package
> 	if [ $i -eq 1 ]; then 
> 		Fsplit claws-mail-plugins-acpinotifier usr/* 
> 	fi
> 	if [ $i -eq 2 ]; then 
> 		Fsplit claws-mail-plugins-attremover usr/* 
> 	fi
> 	if [ $i -eq 3 ]; then 
> 		Fsplit claws-mail-plugins-attachwarner usr/* 
> 	fi

this part looks ugly. it would suggest using something like:

for subpkg in ${subpkgs[@]}
do
        dir=${subpkg//claws-mail-plugins-}
        [ ! -d $dir -o $dir == "synce" ] && continue
        cd $dir
        Fbuild
        Fsplit claws-mail-plugins-$dir usr/*
        cd ..
done

looks shorter and more readable, isn't it?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : /pipermail/attachments/20080316/9897a4fd/attachment.sig