[Frugalware-devel] FB review claws-mail-extra-plugins

[Gabriel C]

Gabriel C wrote:
> Gabriel C wrote:
>> gaetan (bouleetbil) wrote:
>>> Le Sun, 16 Mar 2008 21:57:51 +0100,
>>> Miklos Vajna <vmiklos at frugalware.org> a écrit :
>>>
>>>> On Sun, Mar 16, 2008 at 08:40:07PM +0100, gaetan <bouleetbil at frogdev.info> wrote:
>>>>>     for dir in `ls`; do
>>>>>         # Continue if it is not a directory or the synce plugin
>>>>>         [ ! -d "$dir" ] && continue
>>>>> 	#for don't make plugin sync
>>>>>      	echo "$dir" | grep synce >/dev/null 2>/dev/null && continue 
>>>>>         cd "$dir"
>>>>> 	Fconf
>>>>>        	Fmake
>>>>> 	Fmakeinstall
>>>>> 	#install split package
>>>>> 	if [ $i -eq 1 ]; then 
>>>>> 		Fsplit claws-mail-plugins-acpinotifier usr/* 
>>>>> 	fi
>>>>> 	if [ $i -eq 2 ]; then 
>>>>> 		Fsplit claws-mail-plugins-attremover usr/* 
>>>>> 	fi
>>>>> 	if [ $i -eq 3 ]; then 
>>>>> 		Fsplit claws-mail-plugins-attachwarner usr/* 
>>>>> 	fi
>>>> this part looks ugly. it would suggest using something like:
>>>>
>>>> for subpkg in ${subpkgs[@]}
>>>> do
>>>>         dir=${subpkg//claws-mail-plugins-}
>>>>         [ ! -d $dir -o $dir == "synce" ] && continue
>>>>         cd $dir
>>>>         Fbuild
>>>>         Fsplit claws-mail-plugins-$dir usr/*
>>>>         cd ..
>>>> done
>>>>
>>>> looks shorter and more readable, isn't it?
>>> Hello,
>>> I can't use ${subpkgs[@]} the archive contain dir notification_plugin-0.15 :-(
>> Hold on I'll take a look in 5 minutes :)
> 
> I found an better way , will post the FB in a bit , I'm doing an quick compile test.
> 

Have a look http://crazy.dev.frugalware.org/FrugalBuild

crazy