[Frugalware-devel] FB review claws-mail-extra-plugins

[gaetan (bouleetbil)]

Le Mon, 17 Mar 2008 22:22:28 +0100,
Gabriel C <crazy at frugalware.org> a écrit :

> gaetan (bouleetbil) wrote:
> > Le Mon, 17 Mar 2008 00:48:50 +0100,
> > Gabriel C <crazy at frugalware.org> a écrit :
> > 
> >> Gabriel C wrote:
> >>> Gabriel C wrote:
> >>>> gaetan (bouleetbil) wrote:
> >>>>> Le Sun, 16 Mar 2008 21:57:51 +0100,
> >>>>> Miklos Vajna <vmiklos at frugalware.org> a écrit :
> >>>>>
> >>>>>> On Sun, Mar 16, 2008 at 08:40:07PM +0100, gaetan <bouleetbil at frogdev.info> wrote:
> >>>>>>>     for dir in `ls`; do
> >>>>>>>         # Continue if it is not a directory or the synce plugin
> >>>>>>>         [ ! -d "$dir" ] && continue
> >>>>>>> 	#for don't make plugin sync
> >>>>>>>      	echo "$dir" | grep synce >/dev/null 2>/dev/null && continue 
> >>>>>>>         cd "$dir"
> >>>>>>> 	Fconf
> >>>>>>>        	Fmake
> >>>>>>> 	Fmakeinstall
> >>>>>>> 	#install split package
> >>>>>>> 	if [ $i -eq 1 ]; then 
> >>>>>>> 		Fsplit claws-mail-plugins-acpinotifier usr/* 
> >>>>>>> 	fi
> >>>>>>> 	if [ $i -eq 2 ]; then 
> >>>>>>> 		Fsplit claws-mail-plugins-attremover usr/* 
> >>>>>>> 	fi
> >>>>>>> 	if [ $i -eq 3 ]; then 
> >>>>>>> 		Fsplit claws-mail-plugins-attachwarner usr/* 
> >>>>>>> 	fi
> >>>>>> this part looks ugly. it would suggest using something like:
> >>>>>>
> >>>>>> for subpkg in ${subpkgs[@]}
> >>>>>> do
> >>>>>>         dir=${subpkg//claws-mail-plugins-}
> >>>>>>         [ ! -d $dir -o $dir == "synce" ] && continue
> >>>>>>         cd $dir
> >>>>>>         Fbuild
> >>>>>>         Fsplit claws-mail-plugins-$dir usr/*
> >>>>>>         cd ..
> >>>>>> done
> >>>>>>
> >>>>>> looks shorter and more readable, isn't it?
> >>>>> Hello,
> >>>>> I can't use ${subpkgs[@]} the archive contain dir notification_plugin-0.15 :-(
> >>>> Hold on I'll take a look in 5 minutes :)
> >>> I found an better way , will post the FB in a bit , I'm doing an quick compile test.
> >>>
> >> Have a look http://crazy.dev.frugalware.org/FrugalBuild
> >>
> >> crazy
> > Hello,
> > thanks I don't think to rename or delete dir. I test it, that work 
> > But you never sleep ;-)
> 
> heh :-P 
> 
> Well I do no worries :)

 FS#2893 - [FB] claws-mail-extra-plugins ;-)

-- 
#--------------------------------------------------------------------------- 
#                            Bouleetbil
#
#---------------------------------------------------------------------------  
#     http://www.frogdev.info
#             _    _
#            (o)--(o)
#           /.______.\
#           \________/
#          ./        \.
#         ( .        , )
#          \ \_\\//_/ /
#           ~~  ~~  ~~
#--------------------------------------------------------------------------- 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
Url : /pipermail/attachments/20080322/dd092807/signature.asc