[Frugalware-devel] fpc-bin update for Krix and other developers :-)

[j3d1f0x]

Le Thu, 23 Oct 2008 15:09:57 +0200,
Miklos Vajna <vmiklos at frugalware.org> a écrit :

> On Wed, Oct 22, 2008 at 01:23:49PM +0200, Thomas <echuu.fox at free.fr>
> wrote:
> > -build() {
> > -	cd $Fsrcdir || Fdie
> > -	mkdir $Fsrcdir/$pkgname || Fdie
> 
> (...)
> > +		cd $Fsrcdir || Fdie
> > +		mkdir $Fsrcdir/$pkgname
> 
> I don't see the purpose of this change.
> 

I did not change but I just had "#extract tarball:" to explain.

> The Fdie is right there, use "mkdir -p foo || Fdie" if you want to
> allow an incremental build.
> 

> Also, prepending two tabs instead of one makes no sense to me.
> 
Where ? For install demos & documentation ?

> Anyway it looks fine, but please don't push this one as-is now, as the
> patch is quite unreadable because of these whitespace changes.
> 
I thought it could be more readable if I "ventilate" the FrugalBuild :-(

> Please just resend a patch whithout whitespace changes, then probably
> you'll earn my ACK. :)
> 
> PS: I just ignored your second mail, I hope it got it right that it
> was just a duplicate.
Yes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-fpc-bin-2.2.2-1-i686.patch
Type: text/x-patch
Size: 2087 bytes
Desc: not available
Url : /pipermail/attachments/20081023/0b55a366/0001-fpc-bin-2.2.2-1-i686.bin